0140454/hackbar

V1.2.3 crash

Arcueld opened this issue · 8 comments

Crash when opening the button "use POST method" Tried reinstalling but it didn't work

but V1.2.2 can be used as usual

I cannot reproduce the crash in Chrome 121.0.6167.85 on Linux.

screen-capture.mp4

Please provide your browser name, browser version and target URL.

Chrome V121.0.6167.86 on win11 crash
Chrome V121.0.6167.86 on win10 work

bandicam.2024-01-26.09-34-56-605.2.mp4

Thanks for report.

I will try to get a Windows 11 to test this.

At this moment, you may use Raw mode to send your request.

Unfortunately, I still cannot reproduce it in Chrome 121.0.6167.86 on Windows 11 Pro 23H2 (Build 22631.3007).

screen-capture.mp4

Google Chrome 120.0.6099.200 windows11 Crash when opening the button "use POST method" Tried reinstalling but it didn't work

Reproducing the crash in Google Chrome 121.0.6167.85 Linux, HackBar 1.2.3.

And I also found that when the POST method switch is selected, postControlWrapped keeps repeating the calculation, with the result cycling between true and false.

const postControlWrapped = computed(() => {
const selectCenter =
enctypeSelectTop.value + enctypeSelectHeight.value / 2
const switchCenter =
postEnabledSwitchTop.value + postEnabledSwitchHeight.value / 2
return selectCenter != switchCenter

It seems that the result of enctypeSelectTop and enctypeSelectHeight depend on the value of postControlWrapped, leading to an infinite loop of rendering?

<VSelect
v-show="isBodyEnabled"
ref="enctypeSelect"
v-model="request.body.enctype"
:class="postControlWrapped ? 'pt-3' : ''"

@HSwift Nice catch!

If you remove code related to postControlWrapped, does it work as expected?

If yes, do you want to create a PR to remove them and add yourself into Contributor list in README? I will accept the PR and release new version as soon as possible.

Version 1.2.4 is uploaded to Chrome Web Store and Firefox Add-ons. It is waiting for review now.