0dataapp/hello

Error code 200?

rosano opened this issue · 1 comments

rosano commented

I tried updating and deleting in the latest Firefox private mode and it seems like there is an alert because the code is 200:
Screen Shot 2021-10-15 at 10 42 04

Screen Shot 2021-10-15 at 10 43 54

I was going to just change solid.js#L158 and solid.js#L165 but I don't know if they're supposed to check for 205:

NoelDeMartin commented

Ok, I just changed it to check for 2XX status codes. I actually do this in my apps already, but I wanted to keep it simpler here.

This is a good example of the challenges of developing Solid apps, so I'm glad we found it :). I was testing this with CSS and it worked properly, but it seems like Inrupt's POD doesn't behave the same way. When this happens, the idea is that you should look at the spec to see if this is a bug on Inrupt's POD or it's working correctly. But I don't see any specific mention about what the response status codes should be. So I suppose it's ok to consider any 2XX as a correct response.