0rpc/zerorpc-node

Fails to build with Node v4.1.0

pensierinmusica opened this issue · 4 comments

pensierinmusica commented

The problem seems related to the msgpack module. I've opened an issue there too:
msgpack/msgpack-node#27

npm ERR! Darwin 14.5.0
npm ERR! argv "/usr/local/Cellar/nvm/versions/node/v4.1.0/bin/node" "/usr/local/Cellar/nvm/versions/node/v4.1.0/bin/npm" "install" "zerorpc"
npm ERR! node v4.1.0
npm ERR! npm  v2.14.3
npm ERR! code ELIFECYCLE

npm ERR! msgpack@0.2.6 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the msgpack@0.2.6 install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the msgpack package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls msgpack
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Ale/Dropbox/Docs/Good Karma/Projects/Distilled/code/back/koa/npm-debug.log

What worries me a bit, looking at the other msgpack issues is that the build seems to fail on many Node versions: https://github.com/msgpack/msgpack-node/issues/

Should this module be swapped for another Node JS version of msgpak, or be substituted entirely with JSON.stringify and JSON.parse? The latter would produce slightly longer strings, but should be way faster with current implementation (as mentioned in msgpack-node docs).

Deleted user commented

Should be fixed with the merge of this PR msgpack/msgpack-node#26

godsflaw commented

new msgpack merged, version bumped to 1.0.0, and pushed to npm

bombela commented

zerorpc uses msgpack to be cross-language. This means we cant get rid of msgpack. Its fine switching to a different msgpack implementation if needed though.