GolangCI report
bombsimon opened this issue · 2 comments
It was easy to implement and configure golangci-lint to lint all the code in this repository. I added a configuration (.golangci.yml) and adapted the code which works great locally. However, when I push to remote the reports over at https://golangci.com/r/github.com/bombsimon/amqp-rpc seems to puck up errors, all of them goimport.
The weird thing is that I had an error in brenchmarks/rpc_test.go which I solved by adding a // nolint-comment. When I added that one I immediately got a new error in middleware/panic_redovery.go for the streadway/amqp import.
We need to figure out why this inconsistency exist and how to remove all our errors at golangci.com.
Suddenly seems OK from PR 61. We'll see what happens when we've merged that to master.
Well, I've merged to master and now everything seems OK. Status is Success, no issues! so I'll close this issue.