Add Github CI checks for linting etc

Question

Add Github CI checks for linting etc

norswap opened this issue 9 months ago · 3 comments

We should run the global makefile's make check in github CI and ensure it exits with a zero error code (meaning everything passed as expected).

Here's an example of the same thing in the roll-op repo.

Note that we don't need to "build": the contracts tests will build them automatically, and the typescript code doesn't need a build step. HOWEVER, we will need make setup first to install all dependencies.

Answer 1 · 2024-02-19T08:56:26.000Z

Hi, can I take this issue?

Answer 2 · 2024-02-19T22:06:24.000Z

Should I include fix for typescript linter issue in my PR or is it better to have another one to ensure that linter issues are detected by CI ?

Answer 3 · 2024-02-21T09:00:09.000Z

Should I include fix for typescript linter issue in my PR or is it better to have another one to ensure that linter issues are detected by CI ?

It can be in the same PR if there are some remaining linting issues, just make sure they're in separate commits (ideally each lint fix in a separate commit).