0xSpaceShard/starknet-hardhat-plugin

Refactor constructor checking

FabijanC opened this issue · 1 comments

FabijanC commented

starknet-hardhat-plugin/src/types/index.ts

Line 379 in 18363cc

private resolveContructorPredicate(): (abiEntry: starknet.AbiEntry) => boolean {

Plan:

  • if constructors array is empty, we return a dummy always-false predicate
  • otherwise (meaning if length == 1, since we earlier checked if > 1), we return a predicate comparing with this only constructor name/selector

We can also consider dropping the predicate approach, it's not like we'll have multiple predicates.

remiroyc commented

I'd be glad to handle this issue