10up/Ad-Refresh-Control

Error while saving settings for the first time

cadic opened this issue · 1 comments

cadic commented

Describe the bug

When saving settings on a new install of the plugin, fatal error occurs

Steps to Reproduce

  1. Install plugin
  2. Delete database entry in wp_options for option_name=avc_settings (to make sure this is a new install)
  3. Open Ad Refresh Control settings page
  4. Add a numeric value to "Excluded Advertiser IDs", "Line Items IDs to Exclude" or any value to "Slot IDs to Exclude"
  5. Click "Save Changes"

Fatal error will occur in wp-content/plugins/Ad-Refresh-Control/includes/settings.php on line 297, 321 or 354, depending on which settings field was filled with data.

Screenshots, screen recording, code snippet

image

Environment information

No response

WordPress information

wp-core

version: 6.0
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: /%postname%/
https_status: true
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: local
user_count: -1
dotorg_communication: true

wp-paths-sizes

wordpress_path: /Users/cadic/Sites/wordpress/app/public
wordpress_size: 46.83 MB (49104593 bytes)
uploads_path: /Users/cadic/Sites/wordpress/app/public/wp-content/uploads
uploads_size: 3.36 MB (3525076 bytes)
themes_path: /Users/cadic/Sites/wordpress/app/public/wp-content/themes
themes_size: 13.74 MB (14406748 bytes)
plugins_path: /Users/cadic/Sites/wordpress/app/public/wp-content/plugins
plugins_size: 4.63 GB (4971414292 bytes)
database_size: 707.77 MB (742146048 bytes)
total_size: 5.38 GB (5780596757 bytes)

wp-dropins (1)

db.php: true

wp-active-theme

name: Twenty Twenty-Two (twentytwentytwo)
version: 1.2
author: the WordPress team
author_website: https://wordpress.org/
parent_theme: none
theme_features: core-block-patterns, post-thumbnails, responsive-embeds, editor-styles, html5, automatic-feed-links, block-templates, widgets-block-editor, wp-block-styles, editor-style
theme_path: /Users/cadic/Sites/wordpress/app/public/wp-content/themes/twentytwentytwo
auto_update: Disabled

wp-plugins-active (2)

Ad Refresh Control: version: 1.0.5, author: 10up, Auto-updates disabled
Query Monitor: version: 3.9.0, author: John Blackbourn, Auto-updates disabled

wp-media

image_editor: WP_Image_Editor_GD
imagick_module_version: Not available
imagemagick_version: Not available
imagick_version: Not available
file_uploads: File uploads is turned off
post_max_size: 1000M
upload_max_filesize: 300M
max_effective_size: 300 MB
max_file_uploads: 20
gd_version: bundled (2.1.0 compatible)
gd_formats: GIF, JPEG, PNG, BMP
ghostscript_version: not available

wp-server

server_architecture: Darwin 21.5.0 x86_64
httpd_software: nginx/1.16.0
php_version: 8.0.0 64bit
php_sapi: fpm-fcgi
max_input_variables: 4000
time_limit: 1200
memory_limit: 256M
max_input_time: 600
upload_max_filesize: 300M
php_post_max_size: 1000M
curl_version: 7.79.1 (SecureTransport) LibreSSL/3.3.6
suhosin: false
imagick_availability: false
pretty_permalinks: true
htaccess_extra_rules: false

wp-database

extension: mysqli
server_version: 8.0.16
client_version: mysqlnd 8.0.0
max_allowed_packet: 16777216
max_connections: 151

wp-constants

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /Users/cadic/Sites/wordpress/app/public/wp-content
WP_PLUGIN_DIR: /Users/cadic/Sites/wordpress/app/public/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_ENVIRONMENT_TYPE: local
DB_CHARSET: utf8
DB_COLLATE: undefined

wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable

Code of Conduct

  • I agree to follow this project's Code of Conduct
cadic commented

In PHP 7 it was a Warning, so people might never meet this error before if errors were suppressed on their hosts

  • 👍1