10up/Engineering-Best-Practices

Remove Modernizr on Markup section

smy315 opened this issue · 5 comments

smy315 commented

Modernizr (including HTML5Shiv) is no longer needed and I'm pretty sure that we don't use it on any of our projects. Can we completely remove this section (https://10up.github.io/Engineering-Best-Practices/markup/#html5-structural-elements#modernizr)? I can create a PR.

dana-ross commented

@timwright12 I'm good with removing this if you are. We can always pull in Modernizr if a project calls for classic IE or other browser support, but almost everything my teams work on is IE 11 and up.

timwright12 commented

I'm not against removing the tool, but the concept of feature detection is still valid. @smy315 If you want to create a PR for that area, let's rewrite it to lean on the concept rather than the tool. We still run into some detection with stuff like exports.

tlovett1 commented

I also thought Modernizr was obsolete but certainly could be wrong :)

smy315 commented

PR: #243

Replaced the content for Modernizr section with Feature Detection content. Was told that Modernizr is still utilized so it's included as a link for "feature detection libraries" instead of having a entire section for it.

colorful-tones commented

@smy315 PR looks good to me and makes sense as a new 10upper :)