10up/restricted-site-access

PHPCS linting failures

dkotter opened this issue · 0 comments

Describe the bug

Noticed with recent merges to develop and trunk that we are getting some PHPCS errors. When merging into either of those branches, we lint all files, not just changed files. So we're not getting failures on individual PRs but we are getting failures on those branches.

Looking at the last failed report, seems all the issues have to do with our Compat Validation Tool. Ideally these issues are addressed within that repo but I think we should adjust our PHPCS rules to exclude that directory from linting, as we shouldn't lint dependencies.

Steps to Reproduce

Locally run composer install and then ./vendor/bin/phpcs .. You should see PHPCS issues with test files and with dependency files. Both should be excluded

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct