1Password/onepassword-operator

Operator no longer includes annotations within the created secret

tomjohnburton opened this issue · 7 comments

tomjohnburton commented

Your environment

Operator Version: v1.6.0

Connect Server Version: 1.5.7

Kubernetes Version: 1.23.9

What happened?

In version 1.3.0 of the operator, any annotation I added to the operator would be propagated to the resulting secret. Now, none of my annotations are added.

What did you expect to happen?

I expected the resulting secret to have the annotations I set

Steps to reproduce

  1. Create a OnePasswordItem with annotations
  2. Deploy
  3. Validate the resulting secret doesn't have annotations
  4. Use v1.3.0 of the operator
  5. Do steps 1-3
  6. Validate annotations are there

Notes & Logs

kind: OnePasswordItem
metadata:
  annotations:
    argocd.argoproj.io/compare-options: IgnoreExtraneous
    kubed.appscode.com/sync: "true"

kind: Secret
metadata:
  annotations:
    operator.1password.io/item-path: vaults/***/items/***
    operator.1password.io/item-version: "3"
tomjohnburton commented

I see the commit where it was changed
afa076d

IMO, we should allow users to add extra annotations.

One option could be to add a template field to the spec. A common practise among the k8s community

kind: OnePasswordItem
metadata:
	name: xyz
spec:
	template:
		  annotations:
		     argocd.argoproj.io/compare-options: IgnoreExtraneous
		     kubed.appscode.com/sync: "true"
edif2008 commented

Thank you for raising this with us.
We will further investigate this on our side and come back to you.

vjm commented

Hi, any progress on this, or a workaround perhaps using kustomize?

tomjohnburton commented

I forked it and added the functionality back
https://github.com/tomjohnburton/onepassword-operator

amaldonadomat commented

Any updates on this @edif2008 ?
It's still happening on versions:
Operator Version: 1.8.0
Connect Server Version: 1.7.2