1dot13/source

Assertion error when folding stock on G36C

Asdow opened this issue · 5 comments

Asdow commented

Game consistently hits assertion error related to item 1322 (built-in 2x scope) when folding the integral folding stock on G36C.

jagged_alliance_2-2023-09-23-20_20_59

The scope wasn't pre-attached
I added the 2x-scope (1322) to attachments for g36c (664) and had no more error
Could you try to confirm?

g36c 2xscope

... and I don't know much about real life weapons, but I think a 2x-scope is kinda odd for this weapon
seems more reasonable that this was intented to be a in-build foregrip instead, which would be 1323

if you can confirm that this is working, I could update the gamedir and would change it to 1323 while doing

what also comes to mind are changes made to attachment checks with commit #224 and follow ups

I'm pretty sure I've seen the g36c with scope in previous plays, so maybe the checks don't find it anymore?
this had some hickups with Molle-items as well (fixed), but I'm not qualified to make enough sense out of the code to say for sure

Asdow commented

It probably is meant to be the 2x scope, as G36 came standard with a 1.5x or a 3x scope, and it got copied to the G36C version, though funnily enough, that one actually does not come with a scope sight but iron sights.

I spotted this issue on reddit, and the poster mentioned "always" having this issue, so I'm thinking this may have been in the game before that commit.

Added the missing entry to attachments.xml in gamedir (keeping it a in-build 2x Scope)

1dot13/gamedir@b23e78b