symfony/templating is deprecated
Closed this issue · 9 comments
Bug Report
| Q | A |
|---|---|
| BC Break | yes |
| Version | all |
Summary
Symfony has deprecated the Templating component in 6.x and it's been removed in 7.0. In order to support Symfony 7 we'll need to update the usages of the Templating component to Twig.
I have tried and removed "implements Helper" from UploadHelper altogether (as the Helper only has a getter and setter for Charset which is not used in this bundle), and everything seems to work fine.
That's great @knallcharge! Would you be able to submit a PR with the change?
I have already included all the other sf7-fixes from this fork (https://github.com/evertharmeling/OneupUploaderBundle/tree/sf-7) into mine, so I'll have to setup a new one for it. Basically it's just removing the interface-implementation, but I can look into probably sometime on Monday.
I just created a PR: #438
Note that all sf7-fixes from evertharmeling are also included so credit for that goes to him. I can't create another fork with just the templating-change without deleting my old one which is currently in use, therefore the combined PR.
Not using all featues of the bundle this works for me but a close look is recommended. Also this may break custom filesystem-implementation that may have used the get/setCharset-methods.
What if I merge the changes from @evertharmeling and you can create a follow up PR? I like to keep thing simple and keep the credits.
Sure, good idea.
@knallcharge I've merged the PR from @evertharmeling 👍