`emissions_profile_upstream()` with unmatched products should throw an error
Closed this issue · 1 comments
maurolepore commented
Emission Upstream Profile is only applied to matched products, i.e. we ALWAYS have the data we need. -- Tilmon
#657 (comment)
Currently both emissions*()
fiunctions behave the same way (as they share the underlying code for this feature). However Tilman notes that the *upstream()
should never see data with unmatched products, so the most sensible thing to do is to throw an error or warning if such malformed input is passed (as I do many times in the tests).
maurolepore commented
This seems obsolete. The newer requirement is for emissions_profile*()
to preserve unmatched products.