deprecate mat2d.sign - folks should use double.sign instead

Flare-Flutter/flare_dart/lib/math/mat2d.dart

Lines 6 to 8 in 307ee21

    
           double sign(double value) { 
        
             return value > 0.0 ? 1.0 : -1.0; 
        
           }

https://api.dartlang.org/stable/2.1.0/dart-core/double/sign.html

Nice, I hadn't seen this was a property. Much cleaner. Thanks!

I've done similar before. "Oh, we have that..."

It's always nice when you do figure it out though, "oh that's smart, and of course I should've seen that..." :D

I referenced the wrong issue (too many issue trackers): 7d646bf

Careful! That's a breaking change, right? Deprecate? Changelog? (I do this for a living)

…

On Fri, Jan 18, 2019, 17:40 Luigi Rosso ***@***.*** wrote: It's always nice when you do figure it out though, "oh that's smart, and of course I should've seen that..." :D I referenced the wrong issue (too many issue trackers): 7d646bf <7d646bf> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCiv49Zt6pdiDxwliccrKKVhTcqzvdks5vEneegaJpZM4aI5CM> .

It shouldn't be, but it could be if someone really went out of there way to use that function :) It was intended to be used internally (this was one of the first dart things I wrote). It was one of the first libs I wrote in dart, so yes it shouldn't have been exposed

dartdoc will keep you honest :-) https://pub.dartlang.org/documentation/flare_dart/latest/math_mat2d/math_mat2d-library.html

…

On Fri, Jan 18, 2019 at 6:18 PM Luigi Rosso ***@***.***> wrote: It shouldn't be, but it could be if someone really went out of there way to use that function :) It was intended to be used internally (this was one of the first dart things I wrote). It was one of the first libs I wrote in dart, so yes it shouldn't have been exposed — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCigz3LpasGqCSLG4f8-efJk_HCTrJks5vEoBhgaJpZM4aI5CM> .

Oh that’s great, more new things :) thanks

	double sign(double value) {
	return value > 0.0 ? 1.0 : -1.0;
	}