3-manifolds/SnapPy

mktemp is obsolete, use mkstemp with 'ppm' as suffix

Closed this issue · 1 comments

unhyperbolic commented

SnapPy/python/gui.py

Line 91 in 7c1ea66

ppm_file_name = tempfile.mktemp() + ".ppm"

There are two problems with this line: mkstemp or tempfile.TemporaryFile is favored over mktemp. 'ppm' shouldn't be added after the temporary file is created but passed as "suffix = '.ppm'" to the function.

culler commented

Fixed in 18ec953.