`NewAudioFrame` has memory leak bug
Opened this issue · 0 comments
Justme0 commented
In frame_go112.go https://github.com/3d0c/gmf/blob/master/frame_go112.go#L210
Firstly allocate heap memory. If avcodec_fill_audio_frame()
fail, the heap memory will leak:
![image](https://private-user-images.githubusercontent.com/2346101/317113009-45240771-b760-4cd1-b20f-d70f8831af31.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3Nzc3NjUsIm5iZiI6MTczOTc3NzQ2NSwicGF0aCI6Ii8yMzQ2MTAxLzMxNzExMzAwOS00NTI0MDc3MS1iNzYwLTRjZDEtYjIwZi1kNzBmODgzMWFmMzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTdUMDczMTA1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODMxMzMyZTU1YmQ2ODVjNzg5MWI1ODY3Y2Q2ZWU3NjM4NjQxOGE5ZjVmNmY4NmU1NDE0NGVlZmZhODU4YTFmMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-yGz_O3zEsnKCv0ugJ8p5Bh1__iRg8MksIxU4Kez9xs)
(BTW, I miss RAII in C++)