3liz/qgis-atlasprint

Unused variable in the code about QgsFeatureRequest

Gustry opened this issue · 2 comments

Gustry commented

In https://github.com/3liz/qgis-atlasprint/blob/master/filters/atlasprintFilter.py, the variable qReq is writen 3 times but never used.

It seems important for performances but maybe this variable is legacy because there is another QGIS expression which is used.

Gustry commented

@mdouchin Can we close ?

I remember we wanted to keep this ticket despite of #23
It was slightly different IIRC, but this ticket seems legacy now since 2019.

Gustry commented

Closing for lack of feedback