3lvis/Networking

fatalError when body is an invalid image

nsoojin opened this issue · 4 comments

nsoojin commented

Hi,
Right now app crashes due to the fatal error in the initializer of ImageResult enum when the response body cannot be casted to Image.
But I think this should not be a fatal error because it is a problem from backend and developers can recover from and handle such cases.
So rather than fatal-erroring, how about make it a failure (parsing error perhaps?).
If you think the same way, I'll make a PR

3lvis commented

Hi @nsoojin,

Is this what you were talking about #196?

I'm gonna add you as a contributor so it's easier for you to contribute :) If you have any suggestions or want to improve anything we can discuss it in Gitter, might make communication easier.

https://gitter.im/SwiftNetworking/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link

3lvis commented

Fixed in #196

nsoojin commented

wow that was fast!
ok thanks :)
looking forward to contribute!