Null Return on Group scrubs a github team

[jerick1976]

We experienced an issue within our AD environment where the sync script hit a heavily loaded AD server. The result was a query return of zero users for a group that had multiple users in it. The script then proceeded to remove all of the users from the GitHub team.

On the next run the script hit a lightly loaded AD server and repopulated the team but the damage was done.

The request here is to add a check for a null list. If the list is empty, report an error and proceed to the next sync instead of stripping the users from the GitHub team.

[primetheus]

This looks like it's due to #5.

[primetheus]

We can probably add an option to skip null responses... maybe -n|--skip-null or something of the like... that way existing functionality can remain for those who want it, and when we want empty groups to be ignored we can do that

[jerick1976]

The optional switch sounds like a good option to me. In this situation we would use it by default and provide an option for users to run a periodic scrub omitting the option

…

On Wed, Jan 9, 2019 at 9:22 AM Jared Murrell ***@***.***> wrote: We can probably add an option to skip null responses... maybe -n|--skip-null or something of the like... that way existing functionality can remain for those who want it, and when we want empty groups to be ignored we can do that — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbTq8HzMBecQG4NJXLjUlo8MYTyNHs5Rks5vBfsNgaJpZM4Z0QlF> .

[primetheus]

@jerick1976 I've refactored the script to run as a GitHub App in #33. I need to add more checks in, but the CHANGE_THRESHOLD should help with this issue

[primetheus]

Closing. If further functionality is requested please re-open