3scale/3scale-operator

[system] Add PROMETHEUS_EXPORTER_PORT environment

Closed this issue · 7 comments

We are adding more prometheus exporter endpoint to System component.

  • system-app
  • system-sidekiq

Each container of each pod should have different PROMETHEUS_EXPORTER_PORT value

Container Port Service
system-developer 9394 web server
system-master 9395 web server
system-provider 9396 web server
system-sidekiq 9394 sidekiq

The endpoint are accessible from http://{server}:{port}/metrics where server is normally 0.0.0.0 locally

/cc @roivaz to validate and use those ports on OCP staging

I do not know which value should be taken for the web server 9090+ are for prometheus server so not really fit

Maybe use 9394+ as stated in https://github.com/discourse/prometheus_exporter

For SystemApp pods containers, just let us know the port numbers and we will make all the arrangements to have prometheus scraping metrics.

For systemSidekiq, Currently there are exposed metrics at port 9394

SystemSidekiqMetricsPort = 9394
If you change it or add a new metric service, let us know the port number to do all the integration with the prometheus.

@eguzki I updated the table, you can take them as the reference

You can leave the sidekiq as is. We should change if nobody is using it, if it is used then let it be.

Hi @hallelujah,

When you say Each container of each pod should have different PROMETHEUS_EXPORTER_PORT value do you mean we should set/send the environment variable PROMETHEUS_EXPORTER_PORT to the container?

What are the endpoints for the metrics in the system-app containers? /metrics ?

@hallelujah,

As @eguzki said, For system-sidekiq we are already using SystemSidekiqMetricsPort = 9394
Can you make that the default for Sidekiq in system code? Otherwise I understand we would have to explicitely set the PROMETHEUS_EXPORTER_PORT environment variable to 9394, which means performing a migration/upgrade of existing customer deployments

Closing as those ports are defaults if the environment variable is not set see 3scale/porta#2093