Linting

[apennebaker]

We should eventually tidy up our codebase, or mark classes of errors as ignored (e.g. in .jshintrc).

$ make lint | less

     ✗ #12: Line exceeds maximum allowed length.
     ✗ #26: Line exceeds maximum allowed length.
     ✗ #28: Line exceeds maximum allowed length.
     ✗ #55: Throwing strings is forbidden.
     ✗ #62: Throwing strings is forbidden.
     ✗ #68: Line exceeds maximum allowed length.
     ✗ #84: Line exceeds maximum allowed length.
     ✗ #118: Line exceeds maximum allowed length.
     ✗ #126: Line exceeds maximum allowed length.
     ✗ #195: Line exceeds maximum allowed length.
     ✗ #203: Line exceeds maximum allowed length.
     ✗ #204: Line exceeds maximum allowed length.
     ✗ #206: Line exceeds maximum allowed length.
     ✗ #207: Line exceeds maximum allowed length.
     ✗ #209: Line contains a trailing semicolon.
     ✗ #213: Line exceeds maximum allowed length.
     ✗ #214: Line exceeds maximum allowed length.
     ✗ #240: Line exceeds maximum allowed length.
     ✗ #241: Line exceeds maximum allowed length.
     ✗ #242: Line exceeds maximum allowed length.
     ✗ #243: Line exceeds maximum allowed length.
     ✗ #251: Line exceeds maximum allowed length.

✗ Lint! » 22 errors and 0 warnings in 1 file

make: [coffeelint] Error 1 (ignored)
jshint .
deckster.js: line 3, col 0, Identifier '_css_variables' is not in camel case.
deckster.js: line 5, col 0, Identifier '_css_variables' is not in camel case.
deckster.js: line 10, col 0, Identifier 'drag_handle' is not in camel case.
deckster.js: line 11, col 0, Identifier 'expand_handle' is not in camel case.
deckster.js: line 12, col 0, Identifier 'collapse_handle' is not in camel case.
deckster.js: line 17, col 0, Identifier '_css_variables' is not in camel case.
deckster.js: line 20, col 0, Identifier '_css_variables' is not in camel case.
deckster.js: line 24, col 0, Identifier '__$active_drag_card' is not in camel case.
deckster.js: line 24, col 0, Identifier '__active_drag_card_drag_data' is not in camel case.
deckster.js: line 24, col 0, Identifier '__card_data_by_id' is not in camel case.
deckster.js: line 24, col 0, Identifier '__cards_by_id' is not in camel case.
deckster.js: line 24, col 0, Identifier '__cards_needing_resolved_by_id' is not in camel case.
deckster.js: line 24, col 0, Identifier '__cards_needing_resolved_in_order' is not in camel case.
deckster.js: line 24, col 0, Identifier '__col_max' is not in camel case.
deckster.js: line 24, col 0, Identifier '__default_options' is not in camel case.
deckster.js: line 24, col 0, Identifier '__dominate_card_data' is not in camel case.
deckster.js: line 24, col 0, Identifier '__event_callbacks' is not in camel case.
deckster.js: line 24, col 0, Identifier '__next_id' is not in camel case.
deckster.js: line 24, col 0, Identifier '_add_card' is not in camel case.
deckster.js: line 24, col 0, Identifier '_apply_deck' is not in camel case.
deckster.js: line 24, col 0, Identifier '_bind_controls' is not in camel case.
deckster.js: line 24, col 0, Identifier '_force_card_to_position' is not in camel case.
deckster.js: line 24, col 0, Identifier '_identify_problem_cards' is not in camel case.
deckster.js: line 24, col 0, Identifier '_loop_through_spaces' is not in camel case.
deckster.js: line 24, col 0, Identifier '_mark_card_as_resolved' is not in camel case.
deckster.js: line 24, col 0, Identifier '_move_card' is not in camel case.
deckster.js: line 24, col 0, Identifier '_option_draggable' is not in camel case.
deckster.js: line 24, col 0, Identifier '_option_expandable' is not in camel case.
deckster.js: line 24, col 0, Identifier '_resolve_card_position' is not in camel case.
deckster.js: line 24, col 0, Identifier '_resolve_cards' is not in camel case.
deckster.js: line 26, col 0, Identifier '_css_variables' is not in camel case.
deckster.js: line 29, col 0, Identifier '__default_options' is not in camel case.
deckster.js: line 33, col 0, Identifier '__default_options' is not in camel case.
deckster.js: line 34, col 0, Identifier '_option_draggable' is not in camel case.
deckster.js: line 35, col 0, Identifier '_option_draggable' is not in camel case.
deckster.js: line 35, col 28, Expected '!==' and instead saw '!='.
deckster.js: line 35, col 0, Identifier '_option_draggable' is not in camel case.
deckster.js: line 35, col 0, Identifier '_option_draggable' is not in camel case.
deckster.js: line 36, col 14, ['draggable'] is better written in dot notation.
...