42wim/matterircd

Reactions, Edited and Deleted messages

Closed this issue · 9 comments

guilhermepiccoli commented

Hi folks, this is not an issue per se, it's more a enhancement possibility that I'd like to get feedback.

So, is there a way to indicate in IRC when a message is reacted to? Or edited/deleted? I thought in something like: "new message after edit (edited -> was: old msg before editing)". For reactions, something like ":emoji: (Reaction to: )", and the same template for deleted messages. I think deleted messages are the least important, since the user want it deleted heheh

I found this patch (as a Github suggestion on similar issues): 42wim/mm-go-irckit@2cda758
So, is matterircd ignoring emoji reactions ? Also, found issue #192 about edited messages, but seems I'm not seeing them in my IRC client.

Thanks,

Guilherme

guilhermepiccoli commented

OK, I've re-tested and seems it shows the edited message, but in a odd way. I've edited my own message in a private chat with a friend, it came to the IRC as a new private message from..a token! And it shows: "new msg (edited)", but it doesn't refer to the original message that was edited.

42wim commented

What bridge are you talking about, slack or mattermost ?
If mattermost what mattermost version?

guilhermepiccoli commented

I'm talking about Mattermost, version 5.21.0 (Enterprise Edition is seems).
Thanks =)

jdstrand commented

FYI, I confirmed that I cannot see reactions with mattericd 0.19.4, irssi 1.2.2 and Mattermost Version: 5.23.1 Enterprise Edition.

guilhermepiccoli commented

@42wim , do you think that'd be difficult to add in the refactor? I'm not sure if it's something I should pursue myself..maybe too complex?

jdstrand commented

For completeness, I also tested this against 0.20 master (as of now, a1ab35c) and the problem persists.

42wim commented

I'm currently focused on bugfixing, this feature will probably be added later (as slack in matterircd already has this)

  • 🎉1
42wim commented

Supported now on master, you need to set the option prefixContext=true under the [mattermost] section.

The prefixcontext is an experiment, not sure about the UX yet (but there isn't really a better option that I can think off, repeating the whole message constantly isn't a good idea either).

The slack version uses timestamping, but this isn't clear for multiple messages/reactions within a minute.

  • 👍1
guilhermepiccoli commented

Thanks a lot @42wim, gonna test soon!