compile error on macOS 14.6, arm64, Rack SDK 2.5.2, all build tools up to date
Closed this issue · 12 comments
fractalgee commented
The compile on my M1 (arm64) fails miserably with
4ms-vcv % make dist -j2
cmake_rack_plugin target is 'build/plugin.dylib'
cmake -DCMAKE_SYSTEM_NAME=Darwin -DCMAKE_OSX_DEPLOYMENT_TARGET=10.9 -DCMAKE_INSTALL_PREFIX="/Users/georg/Build/4ms-vcv/dep" -DCMAKE_INSTALL_LIBDIR=lib -B build -DRACK_SDK_DIR=/Users/georg/Build/Rack-SDK-arm64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=build/dist -DCMAKE_OSX_ARCHITECTURES="arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.15"
-- The C compiler identification is AppleClang 15.0.0.15000309
-- The CXX compiler identification is AppleClang 15.0.0.15000309
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Load RackSDK.cmake (mapping based on Rack-SDK-2.4.0)
-- Using Rack-SDK in '/Users/georg/Build/Rack-SDK-arm64'
-- Found include/rack.hpp
-- Using PLUGIN_NAME '4msCompany'
-- PLUGIN_DISTRIBUTABLES: plugin.json;res;/Users/georg/Build/4ms-vcv/LICENSE-GPL-v3.txt;/Users/georg/Build/4ms-vcv/LICENSE.md;res;LICENSE.md;LICENSE-GPL-v3.txt;README.md
-- Enabling Optimizations for Non-Debug Build
-- Retaining CMAKE_CXX_STANDARD=20
-- Build Mac OSX Plugin for architecture arm64
-- Installing into '/Users/georg/Build/4ms-vcv/build/dist'
CMake Error at CMakeLists.txt:37 (add_subdirectory):
The source directory
/Users/georg/Build/4ms-vcv/lib/CoreModules
does not contain a CMakeLists.txt file.
CMake Error at CMakeLists.txt:38 (add_subdirectory):
add_subdirectory given source "lib/CoreModules/4ms" which is not an
existing directory.
CMake Error at CMakeLists.txt:39 (add_subdirectory):
The source directory
/Users/georg/Build/4ms-vcv/lib/metamodule-core-interface
does not contain a CMakeLists.txt file.
CMake Error at CMakeLists.txt:40 (add_subdirectory):
The source directory
/Users/georg/Build/4ms-vcv/lib/patch-serial
does not contain a CMakeLists.txt file.
CMake Error at CMakeLists.txt:41 (add_subdirectory):
The source directory
/Users/georg/Build/4ms-vcv/lib/cpputil
does not contain a CMakeLists.txt file.
-- Configuring incomplete, errors occurred!
make: *** [build/plugin.dylib] Error 1
cmake version 3.3.0
danngreen commented
Looks like submodules are not there. I just updated the README to include this:
git submodule update --init --recursive
fractalgee commented
well,
git submodule update --init --recursive
Cloning into '/Users/georg/Build/4ms-vcv/lib/CoreModules'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:4ms/metamodule-core-modules' into submodule path '/Users/georg/Build/4ms-vcv/lib/CoreModules' failed
Failed to clone 'lib/CoreModules'. Retry scheduled
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:4ms/metamodule-patch-serial' into submodule path '/Users/georg/Build/4ms-vcv/lib/patch-serial' failed
Failed to clone 'lib/patch-serial'. Retry scheduled
Cloning into '/Users/georg/Build/4ms-vcv/lib/CoreModules'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:4ms/metamodule-core-modules' into submodule path '/Users/georg/Build/4ms-vcv/lib/CoreModules' failed
Failed to clone 'lib/CoreModules' a second time, aborting
danngreen commented
Ooops looks like I have the submodules using ssh instead of https. I'll fix that, one sec...
danngreen commented
I pushed a fix that uses https instead of ssh (as it should be). You probably will have to do:
git pull
git submodule sync
To have the urls updated.
Thanks for being one of the early bug-finders!
fractalgee commented
not quite there yet:
git pull was fine, so was git submodule sync, and the git submodule update --init --recursive also worked fine, but a make dist bombs still with:
make dist -j2
cmake_rack_plugin target is 'build/plugin.dylib'
cmake -DCMAKE_SYSTEM_NAME=Darwin -DCMAKE_OSX_DEPLOYMENT_TARGET=10.9 -DCMAKE_INSTALL_PREFIX="/Users/georg/Build/4ms-vcv/dep" -DCMAKE_INSTALL_LIBDIR=lib -B build -DRACK_SDK_DIR=/Users/georg/Build/Rack-SDK-arm64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=build/dist -DCMAKE_OSX_ARCHITECTURES="arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.15"
-- Load RackSDK.cmake (mapping based on Rack-SDK-2.4.0)
-- Using Rack-SDK in '/Users/georg/Build/Rack-SDK-arm64'
-- Found include/rack.hpp
-- Using PLUGIN_NAME '4msCompany'
-- PLUGIN_DISTRIBUTABLES: plugin.json;res;/Users/georg/Build/4ms-vcv/LICENSE-GPL-v3.txt;/Users/georg/Build/4ms-vcv/LICENSE.md;res;LICENSE.md;LICENSE-GPL-v3.txt;README.md
-- Enabling Optimizations for Non-Debug Build
-- Retaining CMAKE_CXX_STANDARD=20
-- Build Mac OSX Plugin for architecture arm64
-- Installing into '/Users/georg/Build/4ms-vcv/build/dist'
CMake Error at CMakeLists.txt:41 (add_subdirectory):
The source directory
/Users/georg/Build/4ms-vcv/lib/metamodule-core-interface
does not contain a CMakeLists.txt file.
-- ryml: using C++ standard: C++20
-- ryml: setting C++ standard required: ON
-- ryml: importing subproject c4core (SUBDIRECTORY)... /Users/georg/Build/4ms-vcv/lib/patch-serial/ryml/rapidyaml/ext/c4core
-- c4core: using C++ standard: C++20
-- ryml: -----> target ryml PUBLIC incorporating lib c4core
CMake Error at CMakeLists.txt:43 (add_subdirectory):
The source directory
/Users/georg/Build/4ms-vcv/lib/cpputil
does not contain a CMakeLists.txt file.
-- Configuring incomplete, errors occurred!
make: *** [build/plugin.dylib] Error 1
danngreen commented
Strange... it's still not cloning the submodules.
Maybe it needs a git submodule update --init --force --remote ?
fractalgee commented
the submodule clone seems OK:
git submodule update --init --recursive
Cloning into '/Users/georg/Build/4ms-vcv/lib/CoreModules'...
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial'...
Submodule path 'lib/CoreModules': checked out '5035ab03cee5f0fd8e513021e267f77fae109370'
Submodule path 'lib/patch-serial': checked out '5ddaeebc45cc375c03fc5eb2e7cb75c574ecbee8'
Submodule 'ryml/rapidyaml' (https://github.com/danngreen/rapidyaml.git) registered for path 'lib/patch-serial/ryml/rapidyaml'
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial/ryml/rapidyaml'...
Submodule path 'lib/patch-serial/ryml/rapidyaml': checked out '8c1d6221dea11259bd63b9fadb081002fe064766'
Submodule 'extern/c4core' (https://github.com/biojppm/c4core) registered for path 'lib/patch-serial/ryml/rapidyaml/ext/c4core'
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial/ryml/rapidyaml/ext/c4core'...
Submodule path 'lib/patch-serial/ryml/rapidyaml/ext/c4core': checked out '8f060a4693eef378e92ac0dff35875bc81b910db'
Submodule 'cmake' (https://github.com/biojppm/cmake) registered for path 'lib/patch-serial/ryml/rapidyaml/ext/c4core/cmake'
Submodule 'extern/debugbreak' (https://github.com/biojppm/debugbreak) registered for path 'lib/patch-serial/ryml/rapidyaml/ext/c4core/src/c4/ext/debugbreak'
Submodule 'src/c4/ext/fast_float' (https://github.com/fastfloat/fast_float) registered for path 'lib/patch-serial/ryml/rapidyaml/ext/c4core/src/c4/ext/fast_float'
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial/ryml/rapidyaml/ext/c4core/cmake'...
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial/ryml/rapidyaml/ext/c4core/src/c4/ext/debugbreak'...
Cloning into '/Users/georg/Build/4ms-vcv/lib/patch-serial/ryml/rapidyaml/ext/c4core/src/c4/ext/fast_float'...
Submodule path 'lib/patch-serial/ryml/rapidyaml/ext/c4core/cmake': checked out '9059c98181f944aec83b90a677c96f3b43bd1047'
Submodule path 'lib/patch-serial/ryml/rapidyaml/ext/c4core/src/c4/ext/debugbreak': checked out '5dcbe41d2bd4712c8014aa7e843723ad7b40fd74'
Submodule path 'lib/patch-serial/ryml/rapidyaml/ext/c4core/src/c4/ext/fast_float': checked out '24374ece716db48f974f49da4aa5851aa371cfa9'
git submodule update --init --force --remote:
git submodule update --init --force --remote Submodule path 'lib/CoreModules': checked out '5035ab03cee5f0fd8e513021e267f77fae109370' Submodule path 'lib/cpputil': checked out 'a755e4c8628528f510ba384d833be12350317ce4' Submodule path 'lib/metamodule-core-interface': checked out '613dd682ec1c1f503e5008b23023f6f3554a247d' Submodule path 'lib/patch-serial': checked out '5ddaeebc45cc375c03fc5eb2e7cb75c574ecbee8'
now the build completes with no error. Time to add the plugin to Rack 2.5.2 arm64 and see
danngreen commented
Awesome!
I don't think this particular issue will bite anyone else unless they happened to try to clone submodules via ssh (which is why CI didn't fail, since it's always a fresh build).
fractalgee commented
now we are just missing lots of dark panels:
danngreen commented
All right!!!
Those are all the modules!
I don't have dark skins (yet)
fractalgee commented
all good, dark skins very much appreciated, but all seem to add to a patch fine and work, and also very CPU efficient. Impressed so far. Thanks a bunch for these! 4ms goodness for those of us who do not wish to get divorced ;)
And if you add a donate link, I think many of us would chip in a few bucks each to help offset the dev time/cost to you
danngreen commented
ha ha...thank you! Enjoy...