Does not compile under Windows
mguillemot opened this issue · 1 comments
mguillemot commented
1d12c61 commented out the compilation of inotifywait.exe on Windows in rebar.conf, because a pre-build binary is now included in the source tree.
But e3e8f03 re-introduced the pre_hook. This prevents fs to be used as a dependency to other projects, especially phoenix_live_reload (and thus phoenix itself):
Example output from mix deps.compile
on a brand-new Phoenix 0.11 project on a fresh install of Elixir 1.0.4 on Windows 7 64bit:
==> fs (compile)
'make' is not recognized as an internal or external command,
operable program or batch file.
ERROR: Command [compile] failed!
** (Mix) Could not compile dependency fs, escript.exe "c:/Users/Erhune/.mix/rebar" command failed. If you want to recompile this dependency, please run: mix deps.compile fs
I think e3e8f03 should be reverted and the instructions to build inotifywait.exe on Windows be put in a documentation file for those who really need it.
electricFeel commented
+1