5HT2B/heartbeat

"Longest missing beat" doesn't work as intended

5HT2 opened this issue · 0 comments

5HT2 commented

I'll do my best to explain this, but from what I understand right now it'll set the "record longest missing beat" if

  • Device A has a longer missing beat than record
  • But Device B has sent a recent beat

This behavior is unexpected, because the "current missing beat" is Device B's, since it is the most recent. Which means that you have not been missing for longer than record, only Device A has been missing that long.

This behavior differs from before and doesn't make sense because "record longest missing beat" would imply from all devices, not just one.

Possible solution..? Check if the current missing beat is longer than record, I think