5afe/safe-react

GS026: Invalid owner provided is displayed for the valid owners during batch tx simulation

Opened this issue · 3 comments

Description

GS026: Invalid owner provided is displayed for the valid owners during batch tx simulation

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Gnosis Chain

Steps to reproduce

  1. Go to https://safe-team.dev.gnosisdev.com/app/gno:0x9DF58F04F3e914ED8D972146401C85313A53FecA/transactions/queue
  2. click batch execution for the txs with nonces 38 and 39

Expected result

I would expected that:

  1. GS026 will not be displayed for the owner
  2. any one can execute the tx , so GS026 is not expected for the execution at all

Obtained result

https://dashboard.tenderly.co/public/safe/safe-apps/simulator/78c92fb1-52b8-4dc0-8f45-b974724042c4
image

This seems to be an issue when updating a Safe from 1.1.1 to 1.3.0 and trying to batch this update with any other tx.

Steps to reproduce:

  1. 2/n safe with 1.1.1 contract
  2. Create and fully sign update safe tx
  3. Create a reject tx (or any other) and fully sign it
  4. Open Batch execute dialog and simulate the tx

Example safe with this setup:
https://safe-team.staging.gnosisdev.com/app/rin:0x6ff122E4a97D3c440450602fdc021A19f63bD2c1/balances

IMO the only front end solution I could think of is to exclude Safe update transactions from batch execution

why is this a major bug? as long as users are not blocked and are able to carry out the update as a single transaction, I would consider this minor.