71/dance

Hidden selection indicator doesn't turn off

Closed this issue · 2 comments

Hi the solution in #184 did not work for me. I'm on Dance 0.5.2.
If I set "hiddenSelectionsIndicatorsDecoration": {}, it does not prevent the decorations from being pushed to the editor. For me it still adds the text but with no decoration (see top line of image).
The solution I guess is to give an explicit decorationType === "off" (or similar) condition to

if (decorationType === undefined) {

image

Thanks for making this extension!

71 commented

Hey there,

Actually, the fix mentioned in #184 addresses specifically this issue, but hasn't been submitted to the marketplace yet. In the meantime you can set the color to editor.background, which essentially makes the decoration invisible.

"hiddenSelectionsIndicatorsDecoration": {
    "after": {
        "color": "$editor.background"
    },
    "isWholeLine": true
}

Thanks!