89luca89/terrible

[IMPROVEMENT] Update Dockerfile with last Terrible version

alegrey91 opened this issue · 5 comments

alegrey91 commented
[IMPROVEMENT] Update Dockerfile with last Terrible version
89luca89 commented

We could create a pipelineto release a new image on dockerhub each tag release, what do you think?
@alegrey91 @J4CKR3D

alegrey91 commented

We could create a pipelineto release a new image on dockerhub each tag release, what do you think?
@alegrey91 @J4CKR3D

Dear @89luca89 ,
luckily for us, I've already created this using a github action.
This was the PR: https://github.com/89luca89/terrible/pull/56/files

alegrey91 commented

Anyway we could add the current release variable to add the image tag the the docker image

  • ❤️1
89luca89 commented

We should then improve on that using

docker build --build-arg var_name=${VARIABLE_NAME} (...)

and

${GITHUB_REF##*/} or $(echo $GITHUB_REF | cut -d / -f 3)

for the tag version, so this process of updating the terrible version is automated

what do you think?

alegrey91 commented

It's a good idea

  • ❤️1