Remove MediaRecorder endCard
jimib opened this issue · 1 comments
I'm using the following configuration for the MediaRecorder:
XR8.MediaRecorder.configure({
maxDurationMs: 5000,
maxDimension : 1024,
enableEndCard : false
});
The settings for maxDurationMs and maxDimension are working, but the end card on the video is still being applied.
Figured it out. It's because I was using the XRExtras MediaPreview which has a default configuration setup included:
web/xrextras/src/mediarecorder/capture-config.js
Lines 3 to 6 in 104702f
I had to call to configure and overwrite the default options on the XRExtras as every time that called updateConfig it would override my existing options. This worked:
XR8.MediaRecorder.configure({
maxDurationMs: 5000,
maxDimension : 1024,
enableEndCard : false
});
XRExtras.MediaRecorder.configure({enableEndCard:false});
XRExtras.MediaRecorder.initMediaPreview();
I'm not going to close this as I feel that either the documentation needs updating, or the defaults in the XTExtras need updating to match those in the docs.