9001/copyparty

Browser hangs when previewed many video stream

Closed this issue · 2 comments

hafeoz commented

Describe the bug
Browser will hang and nothing will load when there's many long videos in a folder, while several long videos are previewed and closed.

To Reproduce

  1. Find a folder with several long (long enough so that the video file needs to be streamed) video.
  2. Play one of them. Make sure the full video is not downloaded (watch the video progress bar and make sure it's not "cached")
  3. Exit the preview. Select another video.
  4. Do step 2 again until you can't load anything.
  5. Observe that:
  • You can't load anything in the page - everything will hang in "loading" state
  • You can't load anything from the same site in other pages too
  1. Refresh the problematic page to fix this issue.

Expected behavior
Browser can preview videos properly.

Screenshots
swappy-20240201_203123
(sorry the screenshot is taken in Chinese and I have to blur media names - you definitely won't want to know what I'm watching)

As shown in the screenshot, all requests simply hangs and refuse to connect after the reproduce procedure.

Server details
I'm running latest pip copyparty with HAProxy, but I think it's irrelevant - see "additional context" below for my understanding of the bug.

Client details
It happens on both Firefox 122 and Safari iOS.

Additional context
I think the problem is that videos are not properly terminated - it's simply paused and hidden. All video elements are still there:
swappy-20240201_204334

This causes browser to keep stream connection open - thus creating many GET requests that never finishes.

When a new request is made (to browse new content), the browser refuses to send it to server as it believes that there are already too much connections in transit.

hafeoz commented

For anyone interested: I've "fixed" the bug by simply disabling the preview. It is done using a path-based ACL in HAProxy:

backend copyparty
    http-request return status 200 content-type 'text/javascript' string 'window.baguetteBox = null;' if { path /.cpr/baguettebox.js }
    server default xxx.xxx.xxx.xxx check
9001 commented

Nice! thanks for spotting this :> I'll get it fixed by the next version 👍

And I have to say, very creative workaround 😄

  • 🎉1