9elements/converged-security-suite

pkg/tools/fit: FitEntry Print needs rework

ChriMarMe opened this issue · 1 comments

func (fit *FitEntry) FancyPrint() {
	log.Println("Fit Table PrintOut")
	if fit.Address == type0MagicWord {
		log.Println("FitEntry 0")
		log.Printf("Fit Size: 0x%x\n Entries", fit.Size())
		log.Printf("Version: 0x%x\n", fit.Version)
		log.Printf("Checksum indicator: 0x%x\n", fit.CVType)
} else {
		log.Printf("Component Address: 0x%x\n", fit.Address)
		log.Printf("Component size: 0x%x\n", fit.Size())
		log.Printf("Version: 0x%x\n", fit.Version)
		log.Printf("C_V & Type: 0x%x\n", fit.CVType)
		log.Printf("Checksum: 0x%x\n", fit.CheckSum)
	}
}

Just a list of magic numbers and prints "Fit Table PrintOut) in every call. This doesn't make sense!

Done with #240