bg-prov: bpm-gen is panicking because of out of bounds array access
ansiwen opened this issue · 1 comments
This code is essentially always crashing, because idx
iterates over img.Segs
, but ibbElements
is only of size ibbCount
, which is almost always smaller.
converged-security-suite/pkg/provisioning/bootguard/bootguard.go
Lines 1071 to 1082 in 8e176a0
I could easily fix that, but first I want to have an conversation how that even could happen? Are there no tests at all covering this code?
I worry about the general state of the code, because I don't believe anyone coded it like that, but there rather was some incident like a corrupt merge/rebase, that probably broke a lot more code?
It got introduced by 7df8824 in #355 which indeed was rebased a couple of times.
I was kind of hopping that @zaolin would address this - however he does not. So let me pick it up. I found some time to rework some little things here and there, and can help to fix it up, and build proper testing.
I think when @zaolin was rewrite some code, that code pulled in without testing, and broke everything (as you pointed already out here).
As I said, I am happy to help fix it up.