🔃 Jokes not refreshing quickly

Question

🔃 Jokes not refreshing quickly

ABSphreak opened this issue 4 years ago · 7 comments

ABSphreak commented 4 years ago

Refreshing the jokes takes about an hour due to image caching.

Can be solved by solving #4

karmanya007 commented 4 years ago

😁

👍1

Answer 1 · 2020-10-09T05:24:49.000Z

@karmanya007 this was the issue that you worked on, lol.

Answer 2 · 2020-10-09T05:25:32.000Z

fixed in #18 by @karmanya007

Answer 3 · 2020-10-09T08:38:14.000Z

I'm pretty sure you don't need 1 hour of cache since you are not hitting any APIs you are just getting the jokes from the local file system.

Answer 4 · 2020-10-09T08:40:32.000Z

@anuraghazra should I remove it? would it mess up the randomization time?

Answer 5 · 2020-10-09T08:41:48.000Z

I think you can remove the caching safely and if you got lot more serverless execution in future you can make it 30min cache..

Answer 6 · 2020-10-09T08:44:22.000Z

@anuraghazra thanks for the friendly tip! I would remove it.
Previously when I did that, on Vercel deployment it was working fine,
but on Github READMEs it was not working.
Would have to do some testing.