📱 Not Mobile responsive.
ABSphreak opened this issue · 6 comments
Jokes' card is not mobile responsive.
Impossible, i try and i realise it's impossible haha. (with git)
We can't get any information from user device, so we can't make an api call with generated variables like window.innerHeight.
You can only render your jokes as an jpg image with markdown cause is parsed (cause you download it with <img src="http..."/> and something like <div :html=""> don't existe)
So, if you wan't help we can make a render who like great on mobile and desktop.
@NOPROD you have github-readme-stats on your profile, check those on mobile, working fine. I wanted something similar, but it should also adjust to the text that is given in the card.
try setting proper viewbox on the SVG and don't use any units on the width, height. just give them width="100", height="100"
And yes you cannot make use of responsive text sizes, just make your card maintain it's aspect ratio.. thats best you can do i think.
@anuraghazra I tried doing that, but text was clipping if it was more than 50 characters in one line, so I made it choose the viewbox itself. Do I make a text-breaking mechanism, if it exceeds a certain word per line limit?
Yeah you can do that we also have that in github-readme-stats
https://github.com/anuraghazra/github-readme-stats/blob/master/src/common/utils.js#L145-L160
Great! I will fix it soon.
Thanks for the tips @anuraghazra, really appreciate it.
I will connect on Discord if I'm stuck somewhere.