ABenassi87/ngx-text-diff

Improve way observable works

Opened this issue · 1 comments

I think the usage of the observable is confusing.

  • Why do I have to pass in left and right AND an observable? I should have the option to just pass in an observable or just left/right
  • I think that the properties on the observable should be consistent with the other properties (e.x. rename leftContent to left)
  • Is the observable the only way to get a render update if the data changes? If so, this should be called out in the documentation.
    • Also, it might be useful for me to just update the @Input() and if left or right changes, then it should trigger a re-comparison (e.x. listen to ngOnChanges())

Changing input parameters doesn't change the comparison. How do I manually trigger change.