ACINQ/phoenix

[Bug] No currency conversion in "Technical details" page

dluvian opened this issue · 2 comments

dluvian commented

In the "Technical details" page the (now) fiat values are calculated correctly but the (then) values are not. The number always stays the same even after changing the fiat currency in the display settings.

Example:

  • I receive 1 EUR
  • Checking the technical details I see Amount received ≈ 1 EUR (then), which is correct
  • I change the fiat currency to PHP (1EUR ≈ 60PHP)
  • Checking the technical details again I see Amount received ≈ 1 PHP (then) which is incorrect. It should be Amount received ≈ 60 PHP. The (now) value is correctly shown as 60 PHP though
robbiehanson commented

Note that, when this is fixed, it will display "1 EUR (then)".

This is because we only store a single original amount (in this case EUR). We support 150+ fiat currencies, so we don't store the original amount in every single currency for every single payment.

This could possibly be improved. If you regularly switch your fiat currency in Phoenix, please let us know your use case. We're always interested in learning how the app is used (especially in ways we didn't anticipate).

  • 👍1
dluvian commented

I switch the currency based on where I currently live.