[FEATURE] Add Subject Dialog.
Closed this issue · 13 comments
Amazing! It looks good to me.
How does this look? @ADRE9
Untitled.mp4
@Artistic18 perfect🙌🏻.
I have added the pull request, kindly review it.
@Artistic18 so this will work thes same edit subject page also , right?. You have reused the modal?
@ADRE9 At the moment I have only implemented it for the Add functionality, I was thinking to create another issue for Edit functionality and let someone else work on it.
Yes, go ahead create an issue. I am pretty impressed by your knowledge of Redux .
Ok one more thing. Clicking outside the modal leaves the route to /subject/new. Make it change to /subject so that clicking outside the user may land back to the subject page.
Yes Sure working on it
@ADRE9 Fixed, kindly review the PR.
Attach a working video too.