ADRE9/bunk-manager-mern

[FEATURE] Add Subject Dialog.

Closed this issue · 13 comments

Currently clicking the add button redirects us to a new page.
I think it would be better instead of redirecting to new page, we can use a Form Dialog.
Untitled3

ADRE9 commented

Amazing! It looks good to me.

How does this look? @ADRE9

Untitled.mp4
ADRE9 commented

@Artistic18 perfect🙌🏻.

I have added the pull request, kindly review it.

It's responsive.
Below is the screenshot for mobile devices.
Untitled

ADRE9 commented

@Artistic18 so this will work thes same edit subject page also , right?. You have reused the modal?

@ADRE9 At the moment I have only implemented it for the Add functionality, I was thinking to create another issue for Edit functionality and let someone else work on it.

ADRE9 commented

Yes, go ahead create an issue. I am pretty impressed by your knowledge of Redux .

ADRE9 commented

Ok one more thing. Clicking outside the modal leaves the route to /subject/new. Make it change to /subject so that clicking outside the user may land back to the subject page.

Yes Sure working on it

@ADRE9 Fixed, kindly review the PR.

ADRE9 commented

Attach a working video too.

@ADRE9

Untitled.mp4