Rules Text Search: Stronger Highlighting
Fnorxblohon opened this issue · 5 comments
When searching the rules, matches are highlighted in a slightly lighter gray writing. A bright green would be more discernible, while still providing enough of a contrast for some forms of limited colour perception (guessing here, I'm no expert).
A simple improvement would be to change the highlight colour, using coloured backgrouds may be more effort, as would be a user-settable option for the highlight colour in fore- and background.
So I found out that the color is material_blue_grey_600. Looking into possible replacements.
material_green_500 is already defined in colors.xml and drops into RulesFragment.java nicely. I could try cooking up a pull request for that, but it would be a first for me and may take some time.
Fair ask. The text is formatted using HTML, but no CSS. I tried to use the <mark> tag, but that doesn't seem to be supported. <b> and <u> do a better job of differentiating the text. I also switched it to a darker green. It has to be visible for both light and dark themes (though we can use different highlighting colors for the themes). This seems like a real improvement to me (who is red-green colorblind!)
Geez, that was quick. Thanks!
You caught me at a good time, doing some pre-release cleanup 😁