approved label added because of... ?!
Closed this issue · 4 comments
Describe the bug
on thoth-station/core#218 (comment) the approved label is added, I cannot verify why?!
To Reproduce
Steps to reproduce the behaviour:
dunno :(
Expected behaviour
the approved label is only added when an authorized reviewed approved a PR via an approving github review
Screenshots
n/a
Additional context
n/a
The Bot sesheta-approver which is a cronjob check for positive zuul gate/check (which is check for linting and testing), it adds approved label to the PR,if the zuul check is positive.
We could decommission the sesheta-approver bot as the sesheta-webhooks adds approved label based on the reviewer's review. This should fix this issue.
Thoughts? @goern
sounds good. let's have labels managed by sesheta-webhooks.
sesheta-approver cronjob is suspended.
The job was happy that her fellow :bot: sesheta-webhook would handle the good work from now on.
The issue can be closed.
❤️ that the bots are happy!