Handle reserved names in PEtab parameter mapping
Opened this issue · 3 comments
Some model entity IDs are replaced by amici_{actual_id} during model import, but the current PEtab parameter mapping generated by amici.petab.parameter_mapping.create_parameter_mapping will contain the original IDs instead of the amici-model-IDs. This needs to be changed.
@FFroehlich : Do you see a problem with keeping the original IDs as parameter/state/... IDs and only using the prefixes in the sympy / C++ symbols? This would anyways be more convenient for users.
@FFroehlich : Do you see a problem with keeping the original IDs as parameter/state/... IDs and only using the prefixes in the sympy / C++ symbols? This would anyways be more convenient for users.
sounds good!
Note for implementation: This will require moving the reserved-names handling from SbmlImporter to DEModel or DEExporter. This would anyways be a good idea. In particular, in the context of potentially extracting SBML to ODE conversion from AMICI into a separate package in the future.