AMReX-Astro/MAESTRO

Update SDC Source to work with StarKiller Microphysics

dwillcox opened this issue · 1 comments

The interface from Source_SDC in Maestro to the burner should be updated to work with the StarKiller Microphysics repository.

The SCIENCE/flame problem is a good test, compile with SDC=t

At present the interface is broken so compilation fails.

In going through the SDC bits of the integrators in StarKiller Microphysics it is apparent they're set up for a different sort of SDC in Castro than Maestro has. The Maestro SDC only integrates rho*X and rho*h, whereas Castro integrates rho*X, internal energy, and kinetic energy. Maestro also doesn't need to carry around any unevolved variables.

I think a straightforward way to make the integrators work for both cases is to introduce a preprocessor variable SDC_METHOD with the appropriate logic.

On a related note, we could think about whether there are advantages to using h versus e in MAESTRO, and this may depend on whether (rho*h) is a good conserved quantity for extended stars as it is for small scale flames where we have previously run MAESTRO with SDC.