unused `Results`

Question

unused `Results`

Closed this issue 4 years ago · 4 comments

There are quite a few unused Results in this library.

Normally the compiler would complain about this, but they've been assigned to anonymous variables (let _ = result). This keeps the compiler happy, but doesn't actually address the issue. These are all functions which can fail, and with this pattern they will fail silently, which in my view is even worse than sprinkling unwraps everywhere.

I count 22 instances of fallible functions where the error case is not handled

Answer 1 · 2020-12-06T11:55:37.000Z

Thanks for the issue. Although #5 probably fixes all those

Answer 2 · 2020-12-06T12:06:04.000Z

At this stage that pull request addresses 3 of the 22 instances, but it also adds 3 new ones.

It's a draft of course, I guess we'll see how many remain once it's merged.

Answer 3 · 2020-12-06T16:06:56.000Z

I am currently unsure when #5 will be marked as done. So I will just fix it by myself. Thanks again

Answer 4 · 2020-12-06T16:54:27.000Z

If #5 is merged I'll address them in a follow up PR, but that's out of scope for #5. Better to split it, else the review will be difficult for @arijit79.