AOMediaCodec/iamf

§3.2: On trim signaling order

Closed this issue · 1 comments

Version Source Clause(s)
AOM Working Group Draft, 17 July 2023 Apple §3.2

Comment:

Is the order of num_samples_to_trim_at_end and num_samples_to_trim_at_``start correct? In semantics start comes first. Make sure the order is the same in syntax and semantics.

It seems that the spec describes what is implemented in the reference software: https://github.com/AOMediaCodec/libiamf/blob/de3f346b6892c5d47eb4d4c2a47482a28b0e2252/proto/audio_frame.proto#L11-L12

I agree that it would have been better to have first "start" then "end" but now that it is implemented, it's not worth changing. We could revert the order of paragraphs in the spec to match the syntax order.