APSL/react-native-button

Can we lossen up props.children check?

gorangajic opened this issue · 4 comments

Currently it will show warning if you provided anything else than text. But in react-native it's possible to nest text one into another.

My use case is to show icon next to text

<Button>
    <Icon name="sign-in"/><Text> Sign up </Text>
</Button>

Hi @gorangajic and thanks for your feedback!

Do you want to nest text only or you need to nest any other node inside (to display an icon, for example)?

Please let me know what works best for you and I'll publish a release tomorrow.

Hi @gorangajic!

I'll be more than happy to provide a solution for you :)

Do you want to nest only Text or any view?

Yup I think that Text will work fine.

Thank you

Closing in favour of #23.