Inverted parameters in MMU_GetSectionDescriptor() and MMU_GetPageDescriptor()

Question

Inverted parameters in MMU_GetSectionDescriptor() and MMU_GetPageDescriptor()

ANOSTM opened this issue 2 years ago · 8 comments

Hello,

In CMSIS v5.8.0 (and also in v5.9.0), some parameters are inverted in CMSIS/Core_A/Include/core_ca.h
The call of MMU_APPage and MMU_APSection are not aligned with their definitions ( user <> priv).
See below

MMU_GetSectionDescriptor()
MMU_GetPageDescriptor()

Answer 1 · 2023-03-22T13:46:38.000Z

Thanks for pointing this out.
May I ask you to raise this change as a PR against develop branch, please?

Answer 2 · 2023-03-22T13:56:05.000Z

Could you confirm that you mean Pull Request by PR ?

Answer 3 · 2023-03-22T15:05:57.000Z

Yes, I mean Pull Request ;)

Answer 4 · 2023-03-22T16:28:25.000Z

I created a pull request from a fork : https://github.com/ANOSTM/CMSIS_5/pulls
Is it OK for you ?

Answer 5 · 2023-04-13T08:49:52.000Z

You need to raise the PR against this repo, not internally to your personal fork.

Answer 6 · 2023-04-13T09:59:22.000Z

Hello,

After some discussion, I raised #1613
I saw this PR (1613) has been merged.
So probably the patch is already available, and this PR (1612) can be closed.
Could you confirm ?

Answer 7 · 2023-04-13T10:30:17.000Z

Hello @ANOSTM, this PR can be closed.
The requested changes are already merged with #1613

Answer 8 · 2023-04-13T11:55:02.000Z

Thanks, @GuentherMartin, I overlooked that.