ARMmbed/mbed-os-example-cellular

modem_trace does not work unless mbed-trace is also enabled

dhwalters423 opened this issue · 7 comments

dhwalters423 commented

Documentation lists Turning modem AT echo trace on and Turning on the tracing and trace level as 2 separate sections.

Modem trace only works when mbed-trace is also enabled.

Consider moving Turning modem AT echo trace on inside the Turning on the tracing and trace level section, and adding a note that mbed-trace is required to be enabled to see the modem-trace.

ciarmcom commented

ARM Internal Ref: IOTCELL-1038

AriParkkila commented

Fixed in changes:

The fixes make AT-trace independent of mbed-trace flag.

ashok-rao commented

Thanks @AriParkkila for the quick action. But, I think we should NOT enable AT trace "together" with mbed-trace. This will spit out lots of information (similiar to what happens in the nanostack/cloud client examples). I think it's better to keep these separate and give an option to the user to individually enable either AT or mbed-trace only or both depending on needs..
@dhwalters423 , @MarceloSalazar ok for you?

MarceloSalazar commented

I understand each of the options have different purposes.
I'd suggest giving the option to the user to choose them independently.

dhwalters423 commented

I agree with @ashok-rao and @MarceloSalazar approach here. Doesn't @AriParkkila 's PR accomplish that?

AriParkkila commented

The PR above introduces two individual flags. The both can be enabled separately, that is you can have either one or the both enabled:

  • cellular.debug-at for Turning modem AT echo trace on
  • mbed-trace.enable for Turning on the tracing and trace level

So I think this work just the way you have requested above.

  • 👍3
AriParkkila commented

Thanks, this issue can be closed when mbed-os-5.9.0-oob is merged to master.

  • 👍1