Aanok/jftui

Allow mpv config dir to be set separately

ammgws opened this issue · 2 comments

jftui 0.6.0, libmpv 1.109, libcurl 7.85.0 OpenSSL/1.1.1q, yajl 20100

jftui uses mpv.conf and input.conf files found in $XDG_CONFIG_HOME/jftui, so I am symlinking my mpv config from ~/.config/mpv into the jftui config directory because I want to use the same config. I initially tried the --config-dir argument but this overrides the config dir for the jftui settings file itself as well.

Would it be reasonable to have a separate command --mpv-config-dir that only overrides the config dir path that jftui passes to mpv here:

JF_MPV_ASSERT(JF_MPV_SET_OPTPROP(g_mpv_ctx, "config-dir", MPV_FORMAT_STRING, &g_state.config_dir));
?

If so I can work on it and submit a PR.

Aanok commented

It's not necessarily unreasonable, but I personally solve this problem symlinking mpv.conf and input.conf individually in jftui's config folder. Is there some specific reason you're unwilling to do that? "Two symlinks are more of a hassle than one symlink" is a valid reason :D

Aanok commented

Considering the lack of followup and the presence of a very easy way to do this already, I'm closing as a won't do.