Hardcoded usernames in cmd/compose
Closed this issue · 3 comments
Hi,
Please pay attention on hardcoded usernames when linking this repository from your own scripts:
https://github.com/Accenture/adop-docker-compose/blob/master/cmd/compose#L156
https://github.com/Accenture/adop-docker-compose/blob/master/cmd/compose#L157
https://github.com/Accenture/adop-docker-compose/blob/master/cmd/compose#L164
Hello,
I'm not clear what the issue is here, or are you suggesting it'd be convenient for these values to be environment variables so that other scripts can make use of them once sourced?
Thanks,
Nick
Yes, it would be great if those username will be defined as variables. Right now I've to use sed to replace those values.
Incorrect credential values introduces infinity awaiting loops for services to came up.