accesslint-bot should not comment on closed PR's
Closed this issue · 1 comments
tysongach commented
Scenario
With a typical rebase workflow, it is likely that accesslint-bot will comment on closed/merged PR’s, which can be annoying/noisy (obviously not a show-stopper).
- I open a PR.
- accesslint-bot comments with a few issues.
- The PR sits stays open for a bit; others on the team are merging to
master
- I rebase off
master
locally,push --force
to GitHub to update the PR with the rebase, then immediately merge tomaster
, and pushmaster
. - While step 4 is in progress, AccessLint is running on CI, and finally comes back to comment on the PR, but it's already been closed/merged.
Here’s what that looks like in a PR: thoughtbot/bourbon.io#61
tysongach commented
Moved to Trello: https://trello.com/b/PpFdXtix/accesslint (private link)