ActiveCampaign/mailmason

Separate build process for templates stored in Postmark

derekrushforth opened this issue · 2 comments

derekrushforth commented

We need to modify the build process for templates that are stored in PM. Since it's so specific to PM it shouldn't necessarily be reflected in MailMason, so we need to figure out how to keep this part of the build process separate and out of master.

Here's what needs to change:

  • Prevent premailer task from running – We're already using mustachio to inline CSS on PM.
  • Remove premailer properties from inline CSS – Should be fairly easy with the replace task.
  • Add an HTML comment above the style block – "Style block is collapsed blah blah blah..." The idea you mentioned where we call it out if people can't find the collapsed style block.

One idea is to create a separate Postmark branch that gets used for this only. It would still be public but since it's not in master I don't think it's a huge deal. @garrettdimon thoughts?

garrettdimon commented

But if someone wants to build templates and copy and paste them into Postmark, it's just as relevant, right? Or no?

Could we just create a private fork of it?

derekrushforth commented

Made these changes per our call this morning. This should be only using premailer to build text versions and I added a comment above style block. 43cd1a8